-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: Make java/weak-cryptographic-algorithm
give a reason why the algo is insecure
#18161
base: main
Are you sure you want to change the base?
Java: Make java/weak-cryptographic-algorithm
give a reason why the algo is insecure
#18161
Conversation
java/weak-cryptographic-algorithm
give a reason why the algo is insecure
This changes the order of the algorithms in the regex, but I don't think that makes any difference.
399bcd6
to
95d26d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight suggested tweak, otherwise LGTM
Co-authored-by: Chris Smowton <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5959a73
To do:
Make an internal companion PR to update the language test that is failing.Pull Request checklist
All query authors
.qhelp
. See the documentation in this repository.Internal query authors only
.ql
,.qll
, or.qhelp
files. See the documentation (internal access required).Changes are validated at scale (internal access required).Adding a new query? Consider also adding the query to autofix.