-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix(azure devops): fix migration version on a fresh install #83290
Conversation
❌ 3 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: who will go under this feature flag ?
we already use this ff to gate if we use the new devops integrations or not. though its currently ga'ed, using the flag will make rollback easier if needed. we will eventually remove this flag |
when the integration is freshly installed, we need to make sure the migration version number is set to 1 as we use this metadata to determine what method we will use to refresh the tokens.
i wrote tests to make sure we refresh correctly when a new integration is installed as well.
to completely fix the bug, we need to do a backfill for all new integrations to update the metadata so we can grab the refresh correctly.