ref(project): use hasFlags flag for CTA check #83282
Open
+37
−36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use the newly implemented
hasFlags
project flag as the final layer to determine whether the CTA should be shown.TLDR: the CTA only shows up if... project has never sent flags before,
event.contexts.flags
is undefined, the platform is correct, & the org is under the cta flag.here are the following possible code paths (all are tested)
event.contexts.flags = [ ... ]
-> flag table renderedevent.contexts.flags = [ ]
-> empty stateevent.contexts.flags = undefined
andhasFlags = true
-> empty stateevent.contexts.flags = undefined
andhasFlags = false
andfeature-flag-cta = true
andplatform in [javascript, python]
-> CTA shownevent.contexts.flags = undefined
andfeature-flag-cta = true
andplatform !in [javascript, python]
-> section hiddenevent.contexts.flags = undefined
andfeature-flag-cta = false
-> section hidden