ref(tsc): convert adminQuotas to FC #83266
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
michellewzhang
commented
Jan 10, 2025
Comment on lines
26
to
27
| const since = new Date().getTime() / 1000 - 3600 * 24 * 7; | ||
| const resolution = '1h'; |
There was a problem hiding this comment.
it didn't seem like these needed to be put into a state?
scttcper
reviewed
Jan 10, 2025
Co-authored-by: Scott Cooper <[email protected]>
michellewzhang
commented
Jan 10, 2025
| staleTime: 0, | ||
| }); | ||
| const [since] = useState(() => new Date().getTime() / 1000 - 3600 * 24 * 7) | ||
| const resolution = '1h'; |
There was a problem hiding this comment.
@scttcper same for resolution?
Suggested change
| const resolution = '1h'; | |
| const [resolution] = useState(() => '1h'); |
michellewzhang
commented
Jan 10, 2025
michellewzhang
commented
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to https://github.com/getsentry/frontend-tsc/issues/2