feat(taskworker) Add concurrent worker #83254
Open
+408
−271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the taskworker process to be a multiprocess concurrent worker. This will help enable higher CPU usage in worker pods, as we can pack more concurrent CPU operations into each pod (at the cost of memory).
The main process is responsible for:
Each child process handles:
Instead of using more child processes to enforce timeouts, I've used SIGALRM. I've verified that tasks like
Do not paralyze workers with infinite loops.
When a worker is terminated, it uses an
Event
to have children exit, and then drains any results. If there are tasks in the_child_tasks
queue will not be completed, and instead will sent to another worker when theprocessing_deadline
on the activations expires.