Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify limitations of attachment scrubbing #12281

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Clarify limitations of attachment scrubbing #12281

merged 3 commits into from
Jan 9, 2025

Conversation

jjbayer
Copy link
Member

@jjbayer jjbayer commented Jan 8, 2025

DESCRIBE YOUR PR

IS YOUR CHANGE URGENT?

  • None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

ref: getsentry/relay#4368

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 8:09am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 8:09am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 8:09am

Copy link

codecov bot commented Jan 8, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.37MB 9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.28MB 6 bytes (-0.0%) ⬇️

@jjbayer jjbayer marked this pull request as ready for review January 8, 2025 15:49
@jjbayer jjbayer requested a review from a team January 8, 2025 15:49
Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for updating 🫡

@jjbayer jjbayer enabled auto-merge (squash) January 9, 2025 07:56
@jjbayer jjbayer merged commit 8fd3e58 into master Jan 9, 2025
11 checks passed
@jjbayer jjbayer deleted the jjbayer-patch-1 branch January 9, 2025 08:09
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants