Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Less volatile cache keys #3522

Merged
merged 5 commits into from
Jan 13, 2025
Merged

ci: Less volatile cache keys #3522

merged 5 commits into from
Jan 13, 2025

Conversation

BYK
Copy link
Member

@BYK BYK commented Jan 11, 2025

Instead of using direct image hashes, only use hashes from migrations folders for each respective image for cache key generation. Should increase cache hit rate significantly as we don't have migrations much.

Also swaps the key order from sentry-snuba to snuba-senry assuming Snuba has less frequent migration additions.

@BYK BYK changed the title ci: Less volatile cache hashes ci: Less volatile cache keys Jan 11, 2025
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.45%. Comparing base (b439c67) to head (d60ad70).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3522   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files           3        3           
  Lines         184      184           
=======================================
  Hits          183      183           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BYK BYK marked this pull request as ready for review January 11, 2025 23:43
@BYK BYK requested a review from hubertdeng123 January 11, 2025 23:43
@BYK BYK enabled auto-merge (squash) January 11, 2025 23:44
action.yaml Show resolved Hide resolved
@BYK BYK merged commit d807ca4 into master Jan 13, 2025
8 checks passed
@BYK BYK deleted the byk/feat/better-docker-cache-key branch January 13, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants