🤖 Improved Error Handling and Stacktrace Validation #1715
+126
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sentry-autofix[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hi there! This PR was automatically generated by Autofix 🤖
This fix was triggered by [email protected]
The code changes implement more robust error handling in the JSON API processing and introduce a static method to preprocess stacktrace strings in the grouping module. In
json_api.py, the error handling for non-dict JSON requests and validation exceptions has been enhanced to provide clearer response messages and details, replacing genericBadRequestexceptions with a structuredValidationFailureResponse. For thegrouping.py, a new methodpreprocess_stacktracehas been added to clean up and validate stacktrace inputs, ensuring that stacktraces provided are trimmed and not empty, with detailed error messages if validation fails.If you have any questions or feedback for the Sentry team about this fix, please email [email protected] with the Run ID: 1.