Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Fedora packages for 0.7.0 hotfix release #25

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

apyrgio
Copy link
Contributor

@apyrgio apyrgio commented Jul 30, 2024

We have stumbled into an SELinux issue that is present only on Fedora systems (not Qubes ones). In order to fix this issue, we need to label our Podman containers with the container_engine_t SELinux label.

Since this patch strictly affects Fedora systems, and it's just a one-line change, we opt to do the following:

  • Cherry-pick this fix from the main branch into a hotfix-0.7.0 branch.
  • Bump the patch level of the dangerzone-0.7.0 RPMs from 1 to 2, so that existing installations can be updated.

In this commit, we include just the necessary RPMs to achieve the above.

Refs freedomofpress/dangerzone#880

We have stumbled into an SELinux issue that is present only on Fedora
systems (not Qubes ones). In order to fix this issue, we need to label
our Podman containers with the `container_engine_t` SELinux label.

Since this patch strictly affects Fedora systems, and it's just a
one-line change, we opt to do the following:
* Cherry-pick this fix from the main branch into a hotfix-0.7.0 branch.
* Bump the patch level of the dangerzone-0.7.0 RPMs from 1 to 2, so
  that existing installations can be updated.

In this commit, we include just the necessary RPMs to achieve the
above.

Refs freedomofpress/dangerzone#880
@rocodes
Copy link

rocodes commented Jul 31, 2024

Testing

  • Package (+latest pyside companion pkg) installs in Fedora 39 (VM testing) and successfully converts a test file
  • Package (+latest pyside companin pkg) installs in Fedora 40 (real OS) and successfully converts a file

I can approve once CI is passing

Copy link

@rocodes rocodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passing and test plan LGTM. Nice one @apyrgio :shipit:

Copy link
Member

@eloquence eloquence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding +1 per @rocodes and repo permission requirements.

@apyrgio apyrgio merged commit 2c44353 into freedomofpress:main Jul 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants