fix: Missing ledger entry for due amount within limit after waiver #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepeshgarg007
requested changes
Jan 27, 2025
| @@ -93,6 +93,9 @@ def setUp(self): | |||
| repayment_schedule_type=loan_product[3], | |||
| ) | |||
|
|
|||
| if loan_product[0] == "Term Loan Product 4": | |||
There was a problem hiding this comment.
Call this from setup, don't have to add charges this way
| repayment_entry = create_repayment_entry(loan.name, "2025-01-16", 106684.69) | ||
| repayment_entry.submit() | ||
|
|
||
| loan_adjustment = frappe.get_doc( |
There was a problem hiding this comment.
We are not testing anything in this, please check if charge waiver entry is getting generated if only charge is pending under shortfall acceptance limit.
Also test for Interest and penalty and principal as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix missing ledger entry for due amount within limit after waiver