Ensure that furi_record_create is passed a non-NULL data pointer
#4078
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's currently possible to use `furi_record_create` to create and initialize a `FuriRecordData` pointing to NULL. This means its potentially possible for `furi_record_open` to return a NULL pointer which besides not being particularly useful means the Rust wrapper for `Record` can't assume that the returned record is always a non-NULL value. If by chance this is the intended behaviour, then we can just have the Rust wrapper do a `furi_check` itself, but it seems like it would be better to eliminate this potential corner-case at the source.
dcoles
requested review from
skotopes,
DrZlo13,
hedger and
gsurkov
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently possible to use
furi_record_createto create and initialize aFuriRecordDatapointing to NULL.This means its potentially possible for
furi_record_opento return a NULL pointer which besides not being particularly useful means the Rust wrapper forRecordcan't assume that the returned record is always a non-NULL value.If by chance this is the intended behaviour, then we can just have the Rust wrapper do a
furi_checkitself, but it seems like it would be better to eliminate this potential corner-case at the source.What's new
furi_record_createnow checks thatdatais a non-NULL pointerVerification
furi_record_createwith a NULLdatapointer should trigger afuri_checksystem crashChecklist (For Reviewer)