Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3925, FL-3942, FL-3944] JS features & bugfixes (SDK 0.2) #4075

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

[FL-3925, FL-3942, FL-3944] JS features & bugfixes (SDK 0.2) #4075

wants to merge 5 commits into from

Conversation

portasynthinca3
Copy link
Member

@portasynthinca3 portasynthinca3 commented Jan 20, 2025 •
edited
Loading

What's new

Verification

  • widget view: run the gui.js demo script, menu entry "Widget"
  • GPIO PWM & stop: run the gpio.js demo script and verify that PA7 outputs a PWM signal. Press the back key, verify that the script is interrupted.
  • Error reporting: write and run a script that invokes some kind of error in an event loop callback. Verify that the script stops and that the error is reported.

Remarks

As per usual, I will upload the new version of the SDK package if/when this PR is merged.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@portasynthinca3 portasynthinca3 added the JS JS Runtime, loader and API label Jan 20, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2025 •
edited
Loading

Compiled f7 firmware for commit 03570ddb:

Willy-JL
Willy-JL reviewed Jan 20, 2025
View reviewed changes
applications/system/js_app/js_modules.c
@@ -267,6 +267,8 @@ void js_check_sdk_compatibility(struct mjs* mjs) {

static const char* extra_features[] = {
"baseline", // dummy "feature"
"gpio-pwm",
"widget-view",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"widget-view",
"gui-widget",

Just so it's based on module name?

I'm just nitpicking at this point, amazing work overall 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Willy-JL Willy-JL Willy-JL left review comments

@skotopes skotopes Awaiting requested review from skotopes skotopes is a code owner

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

@Skorpionm Skorpionm Awaiting requested review from Skorpionm Skorpionm is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
JS JS Runtime, loader and API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@portasynthinca3 @Willy-JL