Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added naming for DESFire cards + fix MF3ICD40 cards unable to be read #4058

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Added naming for DESFire cards + fix MF3ICD40 cards unable to be read #4058

wants to merge 1 commit into from
+53 −4

Conversation

Demae
Copy link

@Demae Demae commented Jan 1, 2025 •
edited
Loading

What's new

  • Fixed NFC not detecting MF3ICD40 cards (due to GET_FREE_MEMORY being an unsupported command)
  • Added display names for DESFire cards

Verification

  • Place MF3ICD40 card up to flipper while searching for nfc card, and in my case, it is correctly identified as a MF3ICD40 myki card

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@Demae Demae force-pushed the dev branch 5 times, most recently from 8f38c76 to f2729fb Compare January 12, 2025 06:45
@Demae Demae changed the title Fixed NFC Application not detecting Mifare DESFire MF3ICD40 cards Added naming for DESFire cards + fix MF3ICD40 cards unable to be read Jan 12, 2025
@Demae
Fixed MF3ICD40 DESFire cards soft-locking NFC application due to read…
a1bc211 
… free memory being an unsupported function, added naming for DESFire cards
@flipperdevices flipperdevices deleted a comment from murthal Jan 17, 2025
@flipperdevices flipperdevices deleted a comment from murthal Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes Awaiting requested review from skotopes skotopes is a code owner

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Demae