chore: move CI to GitHub Actions #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the CI from CircleCI to GitHub actions. As GitHub Actions work a bit differently, things needed to change a bit and I took the chance to clean things up a bit. Nonetheless the coverage should be the same. If you compare it to the CircleCI configuration and wonder how different things are, this list of changes might help: - Seperate multicore-sdr run was removed, it's enabled on the normal tests - Building benchmarks was removed as `--all-targets` already implies building the benchmarks - All the `test` jobs are removed, they are already covered by the release mode tests that run for the whole workspace - Some of the `ignored` tests were run separately. Now simply the whole workspace is run in a single job - The `no_gpu` test was renamed to `no-default-features` - `test_darwin` was renamed to `test_macos` - The `test_arm_no_gpu` wasn't ported as the MacOS runner is an M1, hence there is already basic ARM sanity checking
cryptonemo
reviewed
Sep 30, 2024
cryptonemo
reviewed
Sep 30, 2024
|
I'm still working on the self hosted runner setup (w/gpu), but if we use that, I think we should be able to skip a lot of the param generation/usage and dep installs, etc. But that's for a later PR I guess |
Only generate proofs parameters every two months and not on every PR.
cryptonemo
previously approved these changes
Sep 30, 2024
cryptonemo
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the CI from CircleCI to GitHub actions.
As GitHub Actions work a bit differently, things needed to change a bit and I took the chance to clean things up a bit. Nonetheless the coverage should be the same.
If you compare it to the CircleCI configuration and wonder how different things are, this list of changes might help:
--all-targetsalready implies building the benchmarkstestjobs are removed, they are already covered by the release mode tests that run for the whole workspaceignoredtests were run separately. Now simply the whole workspace is run in a single jobno_gputest was renamed tono-default-featurestest_darwinwas renamed totest_macostest_arm_no_gpuwasn't ported as the MacOS runner is an M1, hence there is already basic ARM sanity checking