test: switch from ethers to alloy #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Stebalien
commented
Jan 21, 2025
Stebalien
force-pushed
the
steb/use-alloy
branch
from
56b1956 to
fbe621b
Compare
Alloy is maintained, ethers is not. This lets us get rid of some outdated dependencies as well. fixes #1601
Stebalien
force-pushed
the
steb/use-alloy
branch
from
fbe621b to
d7d3411
Compare
We don't actually use it.
rvagg
reviewed
Jan 22, 2025
rvagg
reviewed
Jan 22, 2025
| @@ -432,21 +428,7 @@ fn test_callactor_revert() { | |||
| } | |||
|
|
|||
| // Much taken from tests/env.rs | |||
| abigen!(CallActorPrecompile, "./tests/contracts/CallActorPrecompile.abi"); | |||
There was a problem hiding this comment.
should we just delete all the .abi files now?
rvagg
approved these changes
Jan 22, 2025
|
I'm going to merge this with all the files in-place because I want to do a bigger cleanup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alloy is maintained, ethers is not. This lets us get rid of some outdated dependencies as well.
fixes #1601