Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add confirmation dialog for undo commit #1909

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Add confirmation dialog for undo commit #1909

merged 4 commits into from
Oct 17, 2023

Conversation

sainad2222
Copy link
Contributor

@sainad2222 sainad2222 commented Oct 1, 2023 •
edited
Loading

It changes the following:

  • Adds confirmation dialog for undo commit in staged changes

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

Closes #1912

@extrawurst
Copy link
Owner

Thanks for the addition. Please make an entry in the changelog

@sainad2222
Copy link
Contributor Author

@extrawurst Added the changelog and fixed lint issues. LMK if anything else needed

@sainad2222
Copy link
Contributor Author

@extrawurst ping

extrawurst
extrawurst reviewed Oct 16, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
extrawurst
extrawurst reviewed Oct 16, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
extrawurst
extrawurst reviewed Oct 16, 2023
View reviewed changes
src/components/reset.rs Outdated Show resolved Hide resolved
extrawurst
extrawurst reviewed Oct 16, 2023
View reviewed changes
src/app.rs Outdated Show resolved Hide resolved
extrawurst
extrawurst reviewed Oct 16, 2023
View reviewed changes
Copy link
Owner

@extrawurst extrawurst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check my comments

@sainad2222 sainad2222 requested a review from extrawurst October 17, 2023 04:28
@extrawurst extrawurst merged commit 0e2b3db into extrawurst:master Oct 17, 2023
@sainad2222 sainad2222 mentioned this pull request Feb 20, 2024
Merged
4 tasks
IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this pull request Jun 4, 2024
@sainad2222 @IndianBoy42
Add confirmation dialog for undo commit (extrawurst#1909)
4407930
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@extrawurst extrawurst Awaiting requested review from extrawurst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confirmation dialog for undo commit
2 participants
@sainad2222 @extrawurst