Update add-practice-exercise script to reference test generator #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasxatzial
approved these changes
Jan 12, 2025
| - Create the test generator in '${generator_tpl_file}' | ||
| - The test generator uses the canonical data from 'https://github.com/exercism/problem-specifications/blob/main/exercises/${slug}/canonical-data.json' | ||
| - Any test cases you don't want to implement, mark them in 'exercises/practice/${slug}/.meta/tests.toml' with "include = false" | ||
| - Run 'bin/generate-exercise-tests ${slug}' to generate the tests |
There was a problem hiding this comment.
There's a mismatch on line 109. This refers to the generator as generate-exercise-tests, whereas the PR that adds the generator refers to it as generate-tests.
ErikSchierboom
commented
Jan 12, 2025
| - Create the test generator in '${generator_tpl_file}' | ||
| - The test generator uses the canonical data from 'https://github.com/exercism/problem-specifications/blob/main/exercises/${slug}/canonical-data.json' | ||
| - Any test cases you don't want to implement, mark them in 'exercises/practice/${slug}/.meta/tests.toml' with "include = false" | ||
| - Run 'bin/generate-exercise-tests ${slug}' to generate the tests |
There was a problem hiding this comment.
Suggested change
| - Run 'bin/generate-exercise-tests ${slug}' to generate the tests | |
| - Run 'bin/generate-tests ${slug}' to generate the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be merged after #728 is merged.