isogram: add generator template #732
Open
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikSchierboom
force-pushed
the
isogram-template
branch
from
99a6883 to
b65c2ec
Compare
tasxatzial
reviewed
Jan 12, 2025
| @@ -0,0 +1,13 @@ | |||
| (ns isogram-test | |||
| (:require [clojure.test :refer [deftest testing is]] | |||
| isogram)) | |||
There was a problem hiding this comment.
Without brackets, the first letter is typically aligned with the bracket above
Suggested change
| isogram)) | |
| isogram)) |
| isogram)) | ||
|
|
||
| {{#test_cases.isIsogram~}} | ||
| (deftest isogram_test_{{idx}} |
There was a problem hiding this comment.
Suggested change
| (deftest isogram_test_{{idx}} | |
| (deftest isogram?_test_{{idx}} |
| (deftest isogram_test_{{idx}} | ||
| (testing "{{description}}" | ||
| {{#expected~}} | ||
| (is (isogram/isogram? "{{input.phrase}}")))) |
There was a problem hiding this comment.
Suggested change
| (is (isogram/isogram? "{{input.phrase}}")))) | |
| (is (true? (isogram/isogram? "{{input.phrase}}"))))) |
| {{#expected~}} | ||
| (is (isogram/isogram? "{{input.phrase}}")))) | ||
| {{else~}} | ||
| (is (not (isogram/isogram? "{{input.phrase}}"))))) |
There was a problem hiding this comment.
Suggested change
| (is (not (isogram/isogram? "{{input.phrase}}"))))) | |
| (is (false? (isogram/isogram? "{{input.phrase}}"))))) |
There was a problem hiding this comment.
There's also a newline at the end of the template, but I'm guessing you did not want to include one?
Edit: there's also a generators/.problem-specifications directory.
|
I'm seeing the issue with the line trimming on this one. How difficult would be to do post-processing? (it looks a bit clunky as a solution). Personally I'm ok with the extra spaces. |
ErikSchierboom
force-pushed
the
isogram-template
branch
from
b65c2ec to
c23ad50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be merged after #728 is merged