Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add approaches for leap #653

Merged
merged 27 commits into from
Jan 16, 2024
Merged

Add approaches for leap #653

merged 27 commits into from
Jan 16, 2024

Conversation

glennj
Copy link
Contributor

@glennj glennj commented Jan 16, 2024

structure and content largely taken from C# and Racket approaches.

@glennj glennj requested a review from a team January 16, 2024 02:38
BNAndras
BNAndras reviewed Jan 16, 2024
View reviewed changes
exercises/practice/leap/.approaches/introduction.md Outdated Show resolved Hide resolved
exercises/practice/leap/.approaches/introduction.md Outdated Show resolved Hide resolved
exercises/practice/leap/.approaches/ternary-operator/content.md Outdated Show resolved Hide resolved
exercises/practice/leap/.approaches/introduction.md Outdated Show resolved Hide resolved
exercises/practice/leap/.approaches/external-tools/content.md Outdated Show resolved Hide resolved
exercises/practice/leap/.approaches/external-tools/content.md Outdated Show resolved Hide resolved
exercises/practice/leap/.approaches/external-tools/content.md Outdated Show resolved Hide resolved
exercises/practice/leap/.approaches/config.json Outdated Show resolved Hide resolved
IsaacG
IsaacG reviewed Jan 16, 2024
View reviewed changes
exercises/practice/leap/.approaches/boolean-chain/content.md Show resolved Hide resolved
exercises/practice/leap/.approaches/config.json Outdated Show resolved Hide resolved
exercises/practice/leap/.approaches/external-tools/content.md Outdated Show resolved Hide resolved
exercises/practice/leap/.approaches/external-tools/content.md Outdated Show resolved Hide resolved
exercises/practice/leap/.approaches/external-tools/content.md Outdated Show resolved Hide resolved
exercises/practice/leap/.approaches/introduction.md Outdated Show resolved Hide resolved
exercises/practice/leap/.approaches/introduction.md Outdated Show resolved Hide resolved
exercises/practice/leap/.approaches/ternary-operator/content.md Outdated Show resolved Hide resolved
exercises/practice/leap/.approaches/ternary-operator/content.md Show resolved Hide resolved
exercises/practice/leap/.approaches/ternary-operator/content.md Show resolved Hide resolved
glennj and others added 20 commits January 16, 2024 08:08
@glennj @BNAndras
correct the code fence language
9d51a4a 
Co-authored-by: András B Nagy <[email protected]>
@glennj @BNAndras
improve wording
684145c 
Co-authored-by: András B Nagy <[email protected]>
@glennj @BNAndras
typo
ef227a7 
Co-authored-by: András B Nagy <[email protected]>
@glennj @BNAndras
Capitalization
8ae2b4c 
Co-authored-by: András B Nagy <[email protected]>
@glennj @BNAndras
Capitalization
b7a128a 
Co-authored-by: András B Nagy <[email protected]>
@glennj @BNAndras
Capitalization
720e722 
Co-authored-by: András B Nagy <[email protected]>
@glennj @BNAndras
Capitalization
0cd3e0d 
Co-authored-by: András B Nagy <[email protected]>
@glennj @BNAndras
Capitalization
32d6ef6 
Co-authored-by: András B Nagy <[email protected]>
@glennj @BNAndras
Capitalization
b0a6ff7 
Co-authored-by: András B Nagy <[email protected]>
@glennj @BNAndras
Capitalization
6e3594c 
Co-authored-by: András B Nagy <[email protected]>
@glennj @BNAndras
Punctuation
f29f1a2 
Co-authored-by: András B Nagy <[email protected]>
@glennj @BNAndras
code
d0bd774 
Co-authored-by: András B Nagy <[email protected]>
@glennj @BNAndras
Capitalization
e51a1fc 
Co-authored-by: András B Nagy <[email protected]>
@glennj @IsaacG
improve wording
9b7ee79 
Co-authored-by: Isaac Good <[email protected]>
@glennj @IsaacG
improve wording
6f800f2 
Co-authored-by: Isaac Good <[email protected]>
@glennj @IsaacG
improve wording
fcc6024 
Co-authored-by: Isaac Good <[email protected]>
@glennj @IsaacG
i
d82c64a 
Co-authored-by: Isaac Good <[email protected]>
@glennj
other review comments
e56da23
@glennj
markdown style
f1c1fba
@glennj
add contributors
345159e
@glennj glennj requested a review from IsaacG January 16, 2024 16:05
@glennj glennj requested a review from BNAndras January 16, 2024 16:05
glennj and others added 2 commits January 16, 2024 15:49
@glennj @IsaacG
punctuation
73d8f2b 
Co-authored-by: Isaac Good <[email protected]>
@glennj @IsaacG
markdown style
903b0e9 
Co-authored-by: Isaac Good <[email protected]>
glennj and others added 4 commits January 16, 2024 16:16
@glennj @BNAndras
Capitalization
01869fb 
Co-authored-by: András B Nagy <[email protected]>
@glennj @BNAndras
Capitalization
a3860b3 
Co-authored-by: András B Nagy <[email protected]>
@glennj @BNAndras
Capitalization
961f14a 
Co-authored-by: András B Nagy <[email protected]>
@glennj
review suggestions
8eda13c
@glennj
Copy link
Contributor Author

glennj commented Jan 16, 2024

I've applied all review suggestions, and I see approvals. Thank you gents.

@glennj glennj merged commit 5e65747 into exercism:main Jan 16, 2024
2 checks passed
@glennj glennj deleted the leap-approaches branch January 16, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BNAndras BNAndras BNAndras approved these changes

@IsaacG IsaacG IsaacG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glennj @IsaacG @BNAndras