Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-program: Remove caching for transition states #13714

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ajsutton
Copy link
Contributor

Description

Removes the cache of transition states. The agreed prestate is only requested once during the bootstrap process so no cache is needed.

@ajsutton ajsutton requested review from a team as code owners January 11, 2025 16:46
@ajsutton ajsutton requested review from clabby and mds1 January 11, 2025 16:46
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.82%. Comparing base (9881eda) to head (7a844ec).

Files with missing lines Patch % Lines
op-program/client/l2/cache.go 71.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13714      +/-   ##
===========================================
- Coverage    47.23%   45.82%   -1.42%     
===========================================
  Files          958      901      -57     
  Lines        80012    75232    -4780     
  Branches       766      766              
===========================================
- Hits         37797    34472    -3325     
+ Misses       39311    38046    -1265     
+ Partials      2904     2714     -190     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests 90.49% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-program/client/l2/cache.go 84.61% <71.42%> (+6.64%) ⬆️

... and 70 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant