Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the unused imports script check support multiline formatted imports #13695

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

AmadiMichael
Copy link
Member

make the unused imports script check support multiline formatted imports, remove unused imports

The types.sol file included in the excluded files array is done since it imports useful types from LibUDT.sol which it does not use and other contract files import them from Types.sol and not LibUDT.sol.

@AmadiMichael AmadiMichael requested a review from a team as a code owner January 10, 2025 17:06
@AmadiMichael AmadiMichael requested a review from tynes January 10, 2025 17:06
@AmadiMichael AmadiMichael self-assigned this Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.

Project coverage is 47.19%. Comparing base (7a293b6) to head (13bdfd4).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
...acts-bedrock/scripts/checks/unused-imports/main.go 9.09% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13695      +/-   ##
===========================================
- Coverage    47.23%   47.19%   -0.04%     
===========================================
  Files          953      953              
  Lines        79700    79709       +9     
  Branches       766      766              
===========================================
- Hits         37644    37620      -24     
+ Misses       39211    39209       -2     
- Partials      2845     2880      +35     
Flag Coverage Δ
cannon-go-tests-32 62.26% <ø> (-1.98%) ⬇️
cannon-go-tests-64 57.35% <ø> (-1.62%) ⬇️
contracts-bedrock-tests 90.49% <ø> (+2.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...es/contracts-bedrock/src/cannon/PreimageOracle.sol 75.91% <ø> (ø)
...acts-bedrock/scripts/checks/unused-imports/main.go 40.90% <9.09%> (-4.71%) ⬇️

... and 33 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant