Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add "expires after" to CertificateRenewal alert description #370

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

Kumm-Kai
Copy link
Contributor

Currently, the alert description does not include when the certificate will expire:
Certificate for "example.org" should be renewed in Kubernetes secret "foo/bar-tls"

After this change:
Certificate for "example.org" should be renewed as it expires after 5d 22h 39m 55s in Kubernetes secret "foo/bar-tls"

@Kumm-Kai Kumm-Kai changed the title Add "expires after" to CertificateRenewal alert description feat: Add "expires after" to CertificateRenewal alert description Jan 14, 2025
@npdgm npdgm self-assigned this Jan 16, 2025
@npdgm
Copy link
Member

npdgm commented Jan 16, 2025

There was no time left in alert descriptions on purpose. Because depending on the Alertmanager sink and how alerts are consumed, the information may not get updated after the alert is fired. Rendering a duration is not a concern when alerts are forwarded as email or to instant messaging, but it can be misleading when alerts are displayed on a dashboard for example.
However it seems that Karma is refreshing from Alertmanager and would not have this issue now. And that's what most people use. So let's add the duration and not worry about very limited edge cases.
Thanks a lot!

@npdgm npdgm merged commit 9299b39 into enix:main Jan 16, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants