[new product] add valkey #6525
Open
[new product] add valkey #6525
+44
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chenrui333
commented
Jan 7, 2025
•
chenrui333
commented
- add valkey, https://github.com/valkey-io/valkey
- https://valkey.io/
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
usta
requested changes
Jan 8, 2025
Co-authored-by: Ömer Fadıl USTA <[email protected]>
usta
approved these changes
Jan 9, 2025
marcwrobel
requested changes
Jan 12, 2025
| versionCommand: valkey-server --version | ||
| releasePolicyLink: https://valkey.io/topics/releases/ | ||
| changelogTemplate: https://github.com/valkey-io/valkey/releases/tag/__LATEST__ | ||
| eoasColumn: true |
There was a problem hiding this comment.
Suggested change
| eoasColumn: true |
Assigning a label for a column activates it too.
Comment on lines
+24
to
+25
| eoas: false | ||
| eol: false |
There was a problem hiding this comment.
Suggested change
| eoas: false | |
| eol: false | |
| eoas: false # not yet documented on https://valkey.io/topics/releases/ | |
| eol: false # not yet documented on https://valkey.io/topics/releases/ |
| methods: | ||
| - git: https://github.com/valkey-io/valkey.git | ||
|
|
||
| releases: |
There was a problem hiding this comment.
Suggested change
| releases: | |
| # Support and EOL date are documented on https://valkey.io/topics/releases/ | |
| releases: |
For maintainers.
| eol: 2029-04-16 | ||
| latest: "7.2.7" | ||
| latestReleaseDate: 2024-10-02 | ||
| --- |
There was a problem hiding this comment.
Suggested change
| --- | |
| --- |
Formatting.
| > that supports a variety of workloads such as caching, message queues, | ||
| > and can act as a primary database. Valkey can run as either a standalone | ||
| > daemon or in a cluster, with options for replication and high availability. | ||
|
|
There was a problem hiding this comment.
The support policy must be documented too. From what I can see on https://valkey.io/topics/releases/:
- bug and security fixes for 3 years (not clear whether it is for major or minor versions),
- extended security support for the latest minor version of each major version for an additional 2 years.
Hopefully valkey-io/valkey-doc#212 will make it clearer.
Comment on lines
+42
to
+44
| The Valkey community strives to release a stable major version once a year. | ||
| Stable minor versions are created as needed in between major releases, | ||
| and we aim to release at least one minor version a year. |
There was a problem hiding this comment.
This should be rephrased to be more neutral : we cannot be used. See https://github.com/endoflife-date/endoflife.date/wiki/Style-Guide#tone-and-text.
usta
requested changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.