-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add append option to palette picker options
#8208
Merged
Merged
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
5fddae9
feat: add tag badge to palette picker
nickofthyme e6813a0
refactor: make title a react node, remove tag prop api
nickofthyme 0f39903
chore: add changelog
nickofthyme 53737e3
fix: linting errors
nickofthyme fb1b41d
chore: update story based on designer input
nickofthyme a31b0fa
Merge branch 'main' into palette-tagging
nickofthyme ebb9f02
chore: update api to append prop
nickofthyme aa965a9
Merge branch 'main' into palette-tagging
nickofthyme ab98e0e
fix: linting errors
nickofthyme 0b20d96
chore: address pr comments
nickofthyme bc39846
chore: add duplicate docs to website
nickofthyme 15417fc
docs: combine appended title sections
mgadewoll abf7db2
refactor: ensure appended title doesn't break on mobile
mgadewoll d702d52
test: update snapshot
mgadewoll 1684acd
test(VRT): add reference images
mgadewoll File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - Updated `EuiColorPalettePicker` - adds `append` to `EuiColorPalettePickerPaletteProps` to support appending custom content to the title |
134 changes: 134 additions & 0 deletions
134
packages/eui/src-docs/src/views/color_picker/color_palette_picker_appended_title.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,134 @@ | ||
| import React, { useState } from 'react'; | ||
| import { css } from '@emotion/react'; | ||
| import { | ||
| euiPaletteColorBlind, | ||
| euiPaletteForStatus, | ||
| euiPaletteForTemperature, | ||
| } from '../../../../src/services'; | ||
|
|
||
| import { | ||
| EuiSwitch, | ||
| EuiSpacer, | ||
| EuiCode, | ||
| EuiText, | ||
| EuiColorPalettePicker, | ||
| } from '../../../../src/components'; | ||
|
|
||
| import { DisplayToggles } from '../form_controls/display_toggles'; | ||
|
|
||
| /** Text wrapper to remove text-decoration on appended text */ | ||
| const AppendedTitleText = ({ label }) => ( | ||
| <EuiText color="subdued" size="xs"> | ||
| <span | ||
| css={css` | ||
| display: inline-block; | ||
| `} | ||
| > | ||
| {label} | ||
| </span> | ||
| </EuiText> | ||
| ); | ||
|
|
||
| const getPalettes = (appendTitles) => [ | ||
| { | ||
| value: 'pallette_1', | ||
| title: 'EUI color blind', | ||
| palette: euiPaletteColorBlind(), | ||
| append: appendTitles && <AppendedTitleText label="fixed" />, | ||
| type: 'fixed', | ||
| }, | ||
| { | ||
| value: 'pallette_2', | ||
| title: 'EUI palette for status', | ||
| palette: euiPaletteForStatus(5), | ||
| append: appendTitles && <AppendedTitleText label="gradient" />, | ||
| type: 'gradient', | ||
| }, | ||
| { | ||
| value: 'pallette_3', | ||
| title: 'EUI palette for temperature', | ||
| palette: euiPaletteForTemperature(5), | ||
| append: appendTitles && <AppendedTitleText label="fixed" />, | ||
| type: 'fixed', | ||
| }, | ||
| { | ||
| value: 'pallette_4', | ||
| title: 'Grayscale', | ||
| palette: [ | ||
| { | ||
| stop: 100, | ||
| color: 'white', | ||
| }, | ||
| { | ||
| stop: 250, | ||
| color: 'lightgray', | ||
| }, | ||
| { | ||
| stop: 320, | ||
| color: 'gray', | ||
| }, | ||
| { | ||
| stop: 470, | ||
| color: 'black', | ||
| }, | ||
| ], | ||
| append: appendTitles && <AppendedTitleText label="gradient with stops" />, | ||
| type: 'gradient', | ||
| }, | ||
| { | ||
| value: 'pallette_5', | ||
| title: 'Grayscale', | ||
| palette: [ | ||
| { | ||
| stop: 100, | ||
| color: 'white', | ||
| }, | ||
| { | ||
| stop: 250, | ||
| color: 'lightgray', | ||
| }, | ||
| { | ||
| stop: 320, | ||
| color: 'gray', | ||
| }, | ||
| { | ||
| stop: 470, | ||
| color: 'black', | ||
| }, | ||
| ], | ||
| append: appendTitles && <AppendedTitleText label="fixed with stops" />, | ||
| type: 'fixed', | ||
| }, | ||
| { | ||
| value: 'custom', | ||
| title: 'Plain text as a custom option', | ||
| type: 'text', | ||
| }, | ||
| ]; | ||
|
|
||
| export default () => { | ||
| const [showAppendedTitles, setShowAppendedTitles] = useState(true); | ||
| const [pallette, setPallette] = useState('pallette_1'); | ||
|
|
||
| return ( | ||
| <> | ||
| <EuiSwitch | ||
| label={ | ||
| <span> | ||
| Display <EuiCode>append</EuiCode> element on title | ||
| </span> | ||
| } | ||
| checked={showAppendedTitles} | ||
| onChange={() => setShowAppendedTitles(!showAppendedTitles)} | ||
| /> | ||
| <EuiSpacer /> | ||
| <DisplayToggles canPrepend={true} canAppend={true} canReadOnly={false}> | ||
| <EuiColorPalettePicker | ||
| palettes={getPalettes(showAppendedTitles)} | ||
| onChange={setPallette} | ||
| valueOfSelected={pallette} | ||
| /> | ||
| </DisplayToggles> | ||
| </> | ||
| ); | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this so that when the badge is placed inside a clickable component, such that clicking the badge will bubble up and trigger a click handler, the cursor should adopt to the parent component style by default. If the badge itself is clickable, this cursor style is overridden.