-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(MultiSelect): update OnEditCallback sample code #5101
Conversation
Reviewer's Guide by SourceryThis PR updates the Sequence diagram for MultiSelect OnEditCallback flowsequenceDiagram
actor User
participant MS as MultiSelect
participant CB as OnEditCallback
participant Items as EditableItems
User->>MS: Enter new value
MS->>CB: Call OnEditCallback(value)
CB->>Items: Search for existing item
alt Item exists
Items-->>CB: Return existing item
else Item does not exist
CB->>Items: Create new item
Items-->>CB: Return new item
end
CB-->>MS: Return selected item
MS-->>User: Update display
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5101 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 633 633
Lines 28136 28136
Branches 4036 4036
=========================================
Hits 28136 28136 ☔ View full report in Codecov by Sentry. |
update OnEditCallback sample code
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5100 #5067
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Documentation:
OnEditCallback
parameter.