-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Transfer): add Height parameter #5095
Conversation
Co-Authored-By: szpeak <[email protected]>
# Conflicts: # src/BootstrapBlazor/BootstrapBlazor.csproj
Reviewer's Guide by SourceryThis pull request introduces a new Height parameter to the Transfer component, allowing users to set the component's height. The implementation includes updates to the component's logic and styles to accommodate the new parameter, as well as a unit test to ensure its correct functionality. State diagram for Transfer component stylingstateDiagram-v2
[*] --> Transfer
Transfer --> NormalState: Height not set
Transfer --> HeightState: Height set
state HeightState {
[*] --> ApplyHeight
ApplyHeight --> SetTransferHeight: Set --bb-transfer-height
SetTransferHeight --> AdjustPanelHeight: Set panel height 100%
AdjustPanelHeight --> CalculateBodyHeight: Calculate body height
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5095 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 632 632
Lines 28096 28105 +9
Branches 4034 4034
=========================================
+ Hits 28096 28105 +9 ☔ View full report in Codecov by Sentry. |
add Height parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5094
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Introduce a 'Height' parameter to the Transfer component, enabling customization of its height. Update the component's CSS to support this new parameter and add a corresponding unit test to ensure its functionality.
New Features:
Enhancements:
Tests: