Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Transfer): add Height parameter #5095

Merged
merged 5 commits into from
Jan 11, 2025
Merged

feat(Transfer): add Height parameter #5095

merged 5 commits into from
Jan 11, 2025

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Jan 11, 2025

add Height parameter

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #5094

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Introduce a 'Height' parameter to the Transfer component, enabling customization of its height. Update the component's CSS to support this new parameter and add a corresponding unit test to ensure its functionality.

New Features:

  • Add a new 'Height' parameter to the Transfer component, allowing users to set a custom height for the component.

Enhancements:

  • Update the Transfer component to conditionally apply CSS classes and styles based on the new 'Height' parameter.

Tests:

  • Add a unit test to verify that the 'Height' parameter is correctly applied to the Transfer component.

Copy link

sourcery-ai bot commented Jan 11, 2025

Reviewer's Guide by Sourcery

This pull request introduces a new Height parameter to the Transfer component, allowing users to set the component's height. The implementation includes updates to the component's logic and styles to accommodate the new parameter, as well as a unit test to ensure its correct functionality.

State diagram for Transfer component styling

stateDiagram-v2
    [*] --> Transfer
    Transfer --> NormalState: Height not set
    Transfer --> HeightState: Height set
    state HeightState {
        [*] --> ApplyHeight
        ApplyHeight --> SetTransferHeight: Set --bb-transfer-height
        SetTransferHeight --> AdjustPanelHeight: Set panel height 100%
        AdjustPanelHeight --> CalculateBodyHeight: Calculate body height
    }
Loading

File-Level Changes

Change Details Files
Added a new Height parameter to the Transfer component.
  • Introduced a new Height parameter in the Transfer component to allow setting the component's height.
  • Updated the component's CSS to apply the height when the Height parameter is set.
  • Modified the component's rendering logic to include the new height-related CSS classes and styles.
src/BootstrapBlazor/Components/Transfer/Transfer.razor.cs
src/BootstrapBlazor/Components/Transfer/Transfer.razor.scss
src/BootstrapBlazor/Components/Transfer/Transfer.razor
Added unit test for the new Height parameter.
  • Created a new unit test to verify that the Height parameter is correctly applied to the Transfer component.
test/UnitTest/Components/TransferTest.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#5094 Provide an easy-to-use height setting for the Transfer component to improve page layout and reduce scrolling complexity
#5094 Make height configuration more user-friendly compared to using CSS variables directly

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Jan 11, 2025
@bb-auto bb-auto bot added this to the v9.2.0 milestone Jan 11, 2025
@ArgoZhang ArgoZhang enabled auto-merge (squash) January 11, 2025 12:44
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟡 Testing: 1 issue found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

test/UnitTest/Components/TransferTest.cs Show resolved Hide resolved
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7f82876) to head (eb6ddad).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5095   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          632       632           
  Lines        28096     28105    +9     
  Branches      4034      4034           
=========================================
+ Hits         28096     28105    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 0d7e077 into main Jan 11, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the feat-transfer branch January 11, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(Transfer): 穿梭框增加高度设置
1 participant