Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): use request.Count parameter on virtualize mode #5089

Merged
merged 8 commits into from
Jan 11, 2025

Conversation

densen2014
Copy link
Member

@densen2014 densen2014 commented Jan 10, 2025

ScrollModeVirtual paging numbers Inaccurate when search conditions change

Issue

fixes #5085

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Fixed a bug where changing search conditions caused inaccurate paging numbers in tables using ScrollModeVirtual.

Copy link

bb-auto bot commented Jan 10, 2025

Thanks for your PR, @densen2014. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copy link

sourcery-ai bot commented Jan 10, 2025

Reviewer's Guide by Sourcery

This pull request fixes a bug in the Table component where the paging numbers were inaccurate when search conditions changed. The fix involves updating the LoadItems method to use the original page size when search conditions are present. This ensures that the correct number of items are displayed on each page, regardless of the search criteria.

Sequence diagram for Table LoadItems with Search Conditions

sequenceDiagram
    participant User
    participant Table
    participant ItemsProvider

    User->>Table: Change Search Conditions
    Table->>ItemsProvider: LoadItems(request)
    Note over ItemsProvider: Check if SearchText exists
    alt SearchText not empty and TotalCount > 0
        ItemsProvider->>ItemsProvider: Calculate pageItems using TotalCount
    else
        ItemsProvider->>ItemsProvider: Use request.Count as pageItems
    end
    ItemsProvider->>ItemsProvider: QueryData()
    ItemsProvider-->>Table: Return ItemsProviderResult
    Table-->>User: Display Updated Results
Loading

File-Level Changes

Change Details Files
Updated the paging logic to handle search conditions correctly.
  • Modified the LoadItems method to use the original page size when search conditions are present. This ensures that the correct number of items are displayed on each page when searching.
  • Added a conditional check for search text within the calculation of _pageItems to determine whether to use the original request count or a count based on the total count and start index.
  • The change ensures that the number of items displayed per page remains consistent, even when the total count changes due to filtering. This prevents issues where the last page might appear empty or incomplete when search criteria are applied and the total count is reduced as a result of filtering.
src/BootstrapBlazor/Components/Table/Table.razor.cs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot requested a review from ArgoZhang January 10, 2025 13:21
@bb-auto bb-auto bot added the bug Something isn't working label Jan 10, 2025
@bb-auto bb-auto bot added this to the v9.2.0 milestone Jan 10, 2025
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Jan 10, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @densen2014 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please complete the PR template properly, especially the risk assessment and verification sections. This helps reviewers better understand the impact and testing done for this pagination-related change.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d533904) to head (e7277e2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5089   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          632       632           
  Lines        28096     28096           
  Branches      4035      4034    -1     
=========================================
  Hits         28096     28096           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ArgoZhang
ArgoZhang previously approved these changes Jan 11, 2025
@ArgoZhang ArgoZhang changed the title fix(Table): ScrollModeVirtual paging numbers Inaccurate when search conditions change fix(Table): use request.Count parameter on virtualize mode Jan 11, 2025
@ArgoZhang ArgoZhang enabled auto-merge (squash) January 11, 2025 12:03
@ArgoZhang ArgoZhang merged commit 7f82876 into main Jan 11, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the alex/table/ScrollModeVirtual#5085 branch January 11, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(table): 虚拟滚动模式, 搜索后会卡在骨架屏界面
2 participants