-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Table): use request.Count parameter on virtualize mode #5089
Conversation
Thanks for your PR, @densen2014. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Reviewer's Guide by SourceryThis pull request fixes a bug in the Table component where the paging numbers were inaccurate when search conditions changed. The fix involves updating the Sequence diagram for Table LoadItems with Search ConditionssequenceDiagram
participant User
participant Table
participant ItemsProvider
User->>Table: Change Search Conditions
Table->>ItemsProvider: LoadItems(request)
Note over ItemsProvider: Check if SearchText exists
alt SearchText not empty and TotalCount > 0
ItemsProvider->>ItemsProvider: Calculate pageItems using TotalCount
else
ItemsProvider->>ItemsProvider: Use request.Count as pageItems
end
ItemsProvider->>ItemsProvider: QueryData()
ItemsProvider-->>Table: Return ItemsProviderResult
Table-->>User: Display Updated Results
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @densen2014 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete the PR template properly, especially the risk assessment and verification sections. This helps reviewers better understand the impact and testing done for this pagination-related change.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5089 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 632 632
Lines 28096 28096
Branches 4035 4034 -1
=========================================
Hits 28096 28096 ☔ View full report in Codecov by Sentry. |
Co-Authored-By: Zeus <[email protected]> Co-Authored-By: Alex chow <[email protected]>
…llModeVirtual#5085 # Conflicts: # src/BootstrapBlazor/BootstrapBlazor.csproj
Co-Authored-By: Alex chow <[email protected]>
Co-Authored-By: Alex chow <[email protected]>
ScrollModeVirtual paging numbers Inaccurate when search conditions change
Issue
fixes #5085
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: