Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for DesignerFrame #12712

Merged

Conversation

Nora-Zhou01
Copy link
Member

@Nora-Zhou01 Nora-Zhou01 commented Jan 6, 2025

Related #10773

Proposed changes

  • Add unit test DesignerFrameTests.cs for public properties and method of the DesignerFrame
  • Enable nullability in DesignerFrameTests.cs
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 98.98990% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.21727%. Comparing base (e91e3bc) to head (e511195).
Report is 183 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12712         +/-   ##
===================================================
+ Coverage   75.75455%   76.21727%   +0.46272%     
===================================================
  Files           3159        3183         +24     
  Lines         635942      640225       +4283     
  Branches       46987       47192        +205     
===================================================
+ Hits          481755      487962       +6207     
+ Misses        150726      148748       -1978     
- Partials        3461        3515         +54     
Flag Coverage Δ
Debug 76.21727% <98.98990%> (+0.46272%) ⬆️
integration 18.14535% <ø> (-0.02943%) ⬇️
production 50.11861% <ø> (+0.80105%) ⬆️
test 97.04178% <98.98990%> (-0.00329%) ⬇️
unit 47.51876% <ø> (+0.98705%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ricardobossan ricardobossan added the waiting-author-feedback The team requires more information from the author label Jan 6, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jan 9, 2025
@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Jan 9, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jan 10, 2025
@ricardobossan ricardobossan added the waiting-author-feedback The team requires more information from the author label Jan 15, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jan 16, 2025
@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Jan 16, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jan 17, 2025
@ricardobossan ricardobossan added the waiting-author-feedback The team requires more information from the author label Jan 17, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jan 22, 2025
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good!

Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit 9a8b5a2 into dotnet:main Jan 22, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants