Enable nullability in DesignerActionMethodItem #12676
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpetrou
force-pushed
the
DesignerActionMethodItem
branch
from
909d588 to
e03833e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12676 +/- ##
===================================================
+ Coverage 76.03108% 76.03455% +0.00346%
===================================================
Files 3181 3181
Lines 639670 639700 +30
Branches 47215 47215
===================================================
+ Hits 486348 486393 +45
+ Misses 149805 149788 -17
- Partials 3517 3519 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
|
||
| public virtual bool IncludeAsDesignerVerb { get; } | ||
|
|
||
| public virtual void Invoke() | ||
| { | ||
| _methodInfo ??= _actionList?.GetType()?.GetMethod(MemberName, BindingFlags.Default | BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic); | ||
| _methodInfo ??= _actionList?.GetType()?.GetMethod(MemberName!, BindingFlags.Default | BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic); |
There was a problem hiding this comment.
Please add a comment explaining in detail why MemberName! can never be null.
There was a problem hiding this comment.
This can actually be null, but I did not want to add an extra exception to it.
@lonitra should I throw an exception instead?
Tanya-Solyanik
added
the
📭 waiting-author-feedback
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Microsoft Reviewers: Open in CodeFlow