-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Darken TabControl in dark mode #12471
base: main
Are you sure you want to change the base?
Darken TabControl in dark mode #12471
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12471 +/- ##
===================================================
- Coverage 75.71876% 75.71412% -0.00465%
===================================================
Files 3152 3152
Lines 635709 635715 +6
Branches 46970 46971 +1
===================================================
- Hits 481351 481326 -25
- Misses 150927 150944 +17
- Partials 3431 3445 +14
Flags with carried forward coverage won't be shown. Click here to find out more. |
This is not an area I specialize in and could use some guidance. My plan is to help tackle the remaining dark mode help wanted issues if this approach is acceptable. I have done my best to glean from the work that has already been done and have been experimenting with the dark mode themes that I see in .msstyles. Am I correct that in an ideal world these controls would not require this additional styling? |
These are also tackled in #11985 |
To me it looks like that PR could be the start of a new API proposal. In this PR, my goal is to fix the issue without introducing any new public APIs. |
Fixes #11953
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow