-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on RemoteExecutor on some files #12379
Remove dependency on RemoteExecutor on some files #12379
Conversation
e3d91a7
to
4b05a67
Compare
4b05a67
to
acddbd1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12379 +/- ##
===================================================
+ Coverage 76.03858% 76.12353% +0.08495%
===================================================
Files 3181 3187 +6
Lines 639670 639990 +320
Branches 47215 47229 +14
===================================================
+ Hits 486396 487183 +787
+ Misses 149756 149269 -487
- Partials 3518 3538 +20
Flags with carried forward coverage won't be shown. Click here to find out more. |
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/Application.ParkingWindowTests.cs
Show resolved
Hide resolved
acddbd1
to
dd8fb7a
Compare
22a7e71
to
db59ce0
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
db59ce0
to
b2d32e2
Compare
|
||
// verify the remote process succeeded | ||
Assert.Equal(RemoteExecutor.SuccessExitCode, invokerHandle.ExitCode); | ||
Control.CheckForIllegalCrossThreadCalls = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be in a try/finally block
8a9dea8
to
ee214ee
Compare
ee214ee
to
b440f5d
Compare
@Tanya-Solyanik I have re-enabled all tests that were previously skipped with the explanation: Additionally, I restored the correct state of the Summary of Attempts:
Both approaches passed local tests but failed automated CI checks. For now, I’m pausing work on this issue to focus on higher-priority tasks. Let me know if you have any suggestions or would like me to revisit this sooner! |
We'll re-open when we are working on this again. |
Fixes #
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Accessibility testing
Test environment(s)
Microsoft Reviewers: Open in CodeFlow