-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve xml comments review 5th DRAFT #12148
Improve xml comments review 5th DRAFT #12148
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12148 +/- ##
===================================================
+ Coverage 76.18249% 76.38745% +0.20495%
===================================================
Files 3194 3202 +8
Lines 640365 644094 +3729
Branches 47239 47525 +286
===================================================
+ Hits 487846 492007 +4161
+ Misses 148983 148540 -443
- Partials 3536 3547 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
''' <exception cref="NotSupportedException">A folder name in the path contains a colon (:) or is in an invalid format.</exception> | ||
''' <exception cref="SecurityException">The user lacks necessary permissions to view the path.</exception> | ||
''' <exception cref="UnauthorizedAccessException">A destination file exists but cannot be accessed.</exception> | ||
Public Sub CopyDirectory(sourceDirectoryName As String, destinationDirectoryName As String, overwrite As Boolean) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this comment can reference docs for the SYstem.IO API via the inheritdocs tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tanya-Solyanik i can fix comment but this is not ready to be reviewed (it should be DRAFT) as it includes all the other small PR’s not yet merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the VB Runtime Proxy Comments to use inheritdoc cref=""
Sometimes I could point to System.IO other files I had to point to FileIO.FileSystem because VB is not always a thin layer over System.IO, in some causes Sub and Function are swapped, return types are different or System.IO does not have all the overloads that VB has plus other similar reasons. The complexity/size of the files has been drastically simplified.
This is still not ready to review.
…ceptions in existing code.
Improve code coverage for upload tests Support more real File Server options
…' into Shorten-long-inline-comments-Review-4th
…ML-Comments-Review-5th-DRAFT
…internal implementation. Use TypeResolver to load SystemConfiguration and add sample configuration for real servers. Add tests for leading ServerConfiguration json files.
…Review-after-FixIssue#9807-3rd
…' into Shorten-long-inline-comments-Review-4th
…ML-Comments-Review-5th-DRAFT
…Review-after-FixIssue#9807-3rd
…' into Shorten-long-inline-comments-Review-4th
…ML-Comments-Review-5th-DRAFT
Addresses improved XML comment in #11984
Proposed changes
Customer Impact
Regression?
Risk
Microsoft Reviewers: Open in CodeFlow