[release/9.0.2xx] allow reading all mcr image names #45906
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
This was referenced Jan 12, 2025
baronfel
force-pushed
the
backport/pr-44738-to-release/9.0.2xx
branch
from
26c91cf to
4d96773
Compare
baronfel
added
Servicing-consider
Area-Containers
This was referenced Jan 13, 2025
baronfel
force-pushed
the
backport/pr-44738-to-release/9.0.2xx
branch
from
4d96773 to
e6ba01e
Compare
baronfel
approved these changes
Jan 14, 2025
|
Approved though email with an additional privacy approval from @dsplaisted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #44738 to release/9.0.2xx
/cc @baronfel
Fixes #44732
Description
The current base-image tracking recognizes only the following images and their variants:
However, there are more uses of MCR-delivered and Microsoft-owned images than these. With the Azure Functions 2.0 integration fully supporting SDK container publishing, it would be good to be able to recognize uses of that team's base images as well.
Customer Impact
There is no change to the customer experience - however having good numbers of the usage of SDK containerization with Azure Functions may help us allocate dev resources to the feature space for more enhancements.
Regression?
No - this is a new feature in 9.0.2xx.
Risk
Low - we have good (new) test coverage here, and this doesn't change any of the logic around consuming the base images themselves, only the recognition of Microsoft images for tagging.