Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-OSS licenses and source from source-build #45881

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove non-OSS licenses and source from source-build #45881

wants to merge 1 commit into from

Conversation

ellahathaway
Copy link
Member

Closes dotnet/source-build#4736

This PR introduces tooling and functionality to remove non-OSS licenses and associated source in prep-source-build.sh. As is, the tooling removes the following files from the VMR:

        deleted:    src/arcade/src/Microsoft.DotNet.Build.Tasks.Installers/build/wix/eula.rtf
        deleted:    src/aspnetcore/src/Installers/Windows/AspNetCoreModule-Setup/ANCMIISExpressV2/ancm_iis_expressv2.wxs
        deleted:    src/aspnetcore/src/Installers/Windows/AspNetCoreModule-Setup/ANCMV2/aspnetcoremodulev2.wxs
        deleted:    src/aspnetcore/src/Installers/Windows/AspNetCoreModule-Setup/IIS-Setup/iisca/wix/iisca.wxs
        deleted:    src/aspnetcore/src/Installers/Windows/AspNetCoreModule-Setup/IIS-Setup/iisca/wix3/iisca.wxs
        deleted:    src/aspnetcore/src/Installers/Windows/AspNetCoreModule-Setup/license/license.rtf
        deleted:    src/aspnetcore/src/Installers/Windows/AspNetCoreModule-Setup/setupstrings.wxl
        deleted:    src/aspnetcore/src/Installers/Windows/HostOptions/Product.wxs
        deleted:    src/aspnetcore/src/Installers/Windows/WindowsHostingBundle/1028/thm.wxl
        deleted:    src/aspnetcore/src/Installers/Windows/WindowsHostingBundle/1029/thm.wxl
        deleted:    src/aspnetcore/src/Installers/Windows/WindowsHostingBundle/1031/thm.wxl
        deleted:    src/aspnetcore/src/Installers/Windows/WindowsHostingBundle/1033/thm.wxl
        deleted:    src/aspnetcore/src/Installers/Windows/WindowsHostingBundle/1036/thm.wxl
        deleted:    src/aspnetcore/src/Installers/Windows/WindowsHostingBundle/1040/thm.wxl
        deleted:    src/aspnetcore/src/Installers/Windows/WindowsHostingBundle/1041/thm.wxl
        deleted:    src/aspnetcore/src/Installers/Windows/WindowsHostingBundle/1042/thm.wxl
        deleted:    src/aspnetcore/src/Installers/Windows/WindowsHostingBundle/1045/thm.wxl
        deleted:    src/aspnetcore/src/Installers/Windows/WindowsHostingBundle/1046/thm.wxl
        deleted:    src/aspnetcore/src/Installers/Windows/WindowsHostingBundle/1049/thm.wxl
        deleted:    src/aspnetcore/src/Installers/Windows/WindowsHostingBundle/1055/thm.wxl
        deleted:    src/aspnetcore/src/Installers/Windows/WindowsHostingBundle/2052/thm.wxl
        deleted:    src/aspnetcore/src/Installers/Windows/WindowsHostingBundle/3082/thm.wxl
        deleted:    src/aspnetcore/src/Installers/Windows/WindowsHostingBundle/ANCM.wxs
        deleted:    src/aspnetcore/src/Installers/Windows/WindowsHostingBundle/Bundle.wxs
        deleted:    src/aspnetcore/src/Installers/Windows/WindowsHostingBundle/DotNetCore.wxs
        deleted:    src/aspnetcore/src/Installers/Windows/WindowsHostingBundle/SharedFramework.wxs
        deleted:    src/fsharp/setup/resources/eula/VF_EULA.CHS.rtf
        deleted:    src/fsharp/setup/resources/eula/VF_EULA.CHT.rtf
        deleted:    src/fsharp/setup/resources/eula/VF_EULA.CSY.rtf
        deleted:    src/fsharp/setup/resources/eula/VF_EULA.DEU.rtf
        deleted:    src/fsharp/setup/resources/eula/VF_EULA.ENU.rtf
        deleted:    src/fsharp/setup/resources/eula/VF_EULA.ESN.rtf
        deleted:    src/fsharp/setup/resources/eula/VF_EULA.FRA.rtf
        deleted:    src/fsharp/setup/resources/eula/VF_EULA.ITA.rtf
        deleted:    src/fsharp/setup/resources/eula/VF_EULA.JPN.rtf
        deleted:    src/fsharp/setup/resources/eula/VF_EULA.KOR.rtf
        deleted:    src/fsharp/setup/resources/eula/VF_EULA.PLK.rtf
        deleted:    src/fsharp/setup/resources/eula/VF_EULA.PTB.rtf
        deleted:    src/fsharp/setup/resources/eula/VF_EULA.RUS.rtf
        deleted:    src/fsharp/setup/resources/eula/VF_EULA.TRK.rtf
        deleted:    src/roslyn/src/Setup/Roslyn.ThirdPartyNotices/ThirdPartyNotices.rtf
        deleted:    src/roslyn/src/Setup/Roslyn.VsixLicense/EULA.rtf
        deleted:    src/runtime/src/installer/pkg/LICENSE-MSFT.TXT

Some things to consider when reviewing the PR:

  • The name of the files containing the paths to remove: disallowed-sb-licenses-paths.txt. I had a hard time coming up with a name and am open to suggestions on a different one.
  • Combining detect-binaries.sh and remove-licenses.sh? It might be helpful to have a script that shares the common behavior between these two scripts since the two scripts are very similar.
  • Adding logging to FileRemover tool. If this is done, I'd like to explore sharing the logging infra from BinaryToolKit rather than duplicate it in FileRemover. This is a potential item to open an issue about and address at a later time.

@ellahathaway ellahathaway requested review from a team as code owners January 10, 2025 23:16
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Jan 10, 2025
@ellahathaway
Copy link
Member Author

Another item to be done as part of this work is to update the VMR Permissible sources documentation (this PR will go into arcade)

This was referenced Jan 11, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should non-OSS licenses and associated source be stripped by prep-source-build.sh?
1 participant
@ellahathaway