Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from microsoft/testfx #45354

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

[main] Update dependencies from microsoft/testfx #45354

wants to merge 33 commits into from
+31 −9

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Dec 6, 2024 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/microsoft/testfx

  • Subscription: 91043ec4-cb05-4190-931d-16d6d3e461e4
  • Build: 20241216.12
  • Date Produced: December 17, 2024 8:27:23 AM UTC
  • Commit: e6030a8189170d6f34abfce517073d2d641cb5fc
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/microsoft/testfx build 20…
3567fbc 
…241206.1

Microsoft.Testing.Platform
 From Version 1.5.0-preview.24604.7 -> To Version 1.5.0-preview.24606.1
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Dec 6, 2024
This was referenced Dec 6, 2024
Open
Open
@dotnet-maestro
Update dependencies from https://github.com/microsoft/testfx build 20…
75074f1 
…241206.4

Microsoft.Testing.Platform
 From Version 1.5.0-preview.24604.7 -> To Version 1.5.0-preview.24606.4
This was referenced Dec 7, 2024
Open
Open
@dotnet-maestro
Update dependencies from https://github.com/microsoft/testfx build 20…
0b0db05 
…241208.1

Microsoft.Testing.Platform
 From Version 1.5.0-preview.24604.7 -> To Version 1.5.0-preview.24608.1
@mariam-abdulla mariam-abdulla enabled auto-merge (squash) December 9, 2024 08:50
@dsplaisted
Copy link
Member

@dotnet/product-construction Can you look at the VMR build failure here?

@ViktorHofer
Copy link
Member

Those were just timeouts because the queues are overbooked.

ViktorHofer and others added 2 commits December 10, 2024 09:57
@ViktorHofer
Merge branch 'main' into darc-main-49744c99-7212-4722-880e-34f8c67032e1
fe48022
@dotnet-maestro
Update dependencies from https://github.com/microsoft/testfx build 20…
0de324d 
…241210.1

Microsoft.Testing.Platform
 From Version 1.5.0-preview.24604.7 -> To Version 1.5.0-preview.24610.1
@build-analysis build-analysis bot mentioned this pull request Dec 10, 2024
Open
MichaelSimons
MichaelSimons reviewed Dec 10, 2024
View reviewed changes
eng/Version.Details.xml Outdated
@@ -664,9 +664,9 @@
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>e77011b31a3e5c47d931248a64b47f9b2d47853d</Sha>
</Dependency>
<Dependency Name="Microsoft.Testing.Platform" Version="1.5.0-preview.24604.7">
<Dependency Name="Microsoft.Testing.Platform" Version="1.5.0-preview.24610.1">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this repo will need to be added to the VMR. To do this, it needs an entry added to https://github.com/dotnet/sdk/blob/main/src/VirtualMonoRepo/source-mappings.json. Additionally since this is going to be required for source-build. This dependency will need the source-build metadata added.

<SourceBuild RepoName="testfx" ManagedOnly="true" />

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may not be required now with this PR but it sounds like it will long term.

@nohwnd
Copy link
Member

nohwnd commented Dec 11, 2024

waiting for this: #45411

@dotnet-maestro
Update dependencies from https://github.com/microsoft/testfx build 20…
5cff55f 
…241211.3

Microsoft.Testing.Platform , MSTest
 From Version 1.5.0-preview.24604.7 -> To Version 1.5.0-preview.24611.3
@v-wuzhai
Copy link
Member

/azp run dotnet-sdk-public-ci,sdk-source-build,sdk-unified-build

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Dec 12, 2024
Open
@ViktorHofer ViktorHofer requested review from a team as code owners December 13, 2024 12:12
@nohwnd
Copy link
Member

nohwnd commented Dec 13, 2024

Yes, just sdk.

@MichaelSimons
Copy link
Member

A VMR repo project will need to be created for testfx.proj at https://github.com/dotnet/sdk/tree/main/src/SourceBuild/content/repo-projects

@MichaelSimons
Copy link
Member

A VMR repo project will need to be created for testfx.proj at https://github.com/dotnet/sdk/tree/main/src/SourceBuild/content/repo-projects

I see this is not in the repo onboarding instructions. I will add it. In the meantime, I would refer to existing projects for examples. The main thing I think that is needed is to define the RepositoryReferences correctly. See https://github.com/dotnet/sdk/blob/main/src/SourceBuild/content/repo-projects/vstest.proj for an example.

ViktorHofer and others added 4 commits December 13, 2024 19:38
@ViktorHofer
Add testfx project
a5576cc
@dotnet-maestro
Update dependencies from https://github.com/microsoft/testfx build 20…
06b31cb 
…241213.3

Microsoft.SourceBuild.Intermediate.testfx , Microsoft.Testing.Platform , MSTest
 From Version 3.8.0-preview.24612.7 -> To Version 3.8.0-preview.24613.3
@dotnet-maestro
Update dependencies from https://github.com/microsoft/testfx build 20…
499716f 
…241213.5

Microsoft.SourceBuild.Intermediate.testfx , Microsoft.Testing.Platform , MSTest
 From Version 3.8.0-preview.24613.3 -> To Version 3.8.0-preview.24613.5
@dotnet-maestro
Update dependencies from https://github.com/microsoft/testfx build 20…
f69cfff 
…241214.1

Microsoft.SourceBuild.Intermediate.testfx , Microsoft.Testing.Platform , MSTest
 From Version 3.8.0-preview.24613.5 -> To Version 3.8.0-preview.24614.1
@ViktorHofer
Copy link
Member

@nohwnd the remaining failures are real ones when building the testfx repo as part of the VMR.

@dotnet-maestro
Update dependencies from https://github.com/microsoft/testfx build 20…
f724df6 
…241216.12

Microsoft.SourceBuild.Intermediate.testfx , Microsoft.Testing.Platform , MSTest
 From Version 3.8.0-preview.24614.1 -> To Version 3.8.0-preview.24616.12
@dkurepa dkurepa mentioned this pull request Dec 18, 2024
Closed
@build-analysis build-analysis bot mentioned this pull request Dec 18, 2024
Open
3 tasks
@v-wuzhai v-wuzhai force-pushed the darc-main-49744c99-7212-4722-880e-34f8c67032e1 branch from 9015c6f to b31446c Compare January 6, 2025 10:10
@Forgind
Copy link
Member

Forgind commented Jan 8, 2025

@nohwnd, any update?

@nohwnd
Copy link
Member

nohwnd commented Jan 8, 2025

Looks like vmr no longer fails on testfx, but rather on the test-templates, which are now part of sdk, checking with our team.

@ViktorHofer
Copy link
Member

The test-templates failure was just a stale issue because the branch was on an old HEAD. I updated the branch. Note that @Evangelink shared concerns regarding source building the testfx repo: dotnet/source-build-reference-packages#1105 (comment)

@Evangelink
Copy link
Member

The test-templates failure was just a stale issue because the branch was on an old HEAD. I updated the branch. Note that @Evangelink shared concerns regarding source building the testfx repo: dotnet/source-build-reference-packages#1105 (comment)

Will reply on the other thread, we have discussed and agreed upon a strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelSimons MichaelSimons MichaelSimons left review comments

@mariam-abdulla mariam-abdulla mariam-abdulla approved these changes

@v-wuzhai v-wuzhai v-wuzhai approved these changes

@mmitche mmitche mmitche approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees
No one assigned
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.