Reclaim RazorProject type from the compiler #11379
Open
+477
−693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ComponentImportProjectFeature does the same work to produce a new byte array for its file content every time it produces a RazorProjectItem. This change computes the byte array once and reuses the same project item rather than creating a new one.
RazorProjectFileSystem has two abstract GetItem overloads that all subclasses must provide an implementation for. However, every subclass implements one GetItem the same way by delegating to the overload. This change just pushes that implementation into RazorProjectFileSystem.
All code that instantiates a NotFoundProjectItem always passes an empty string. This change removes that argument.
This updates up all three versions of MvcImportProjectFeature from Extensions, Extensions.Version1_X, and Extensions.Vserion2_X.
davidwengier
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Razor tooling will be renaming
DocumentSnapshottoRazorDocumentandProjectSnapshottoRazorProject. However, the compiler already declares aRazorProjecttype in a different namespace. To avoid painful conflicts, this change removesRazorProjectfrom the compiler. On closer inspection, it turns out that the compiler'sRazorProjectis an unnecessary abstraction. It only serves as the base type forRazorProjectFileSystemand instances are never exposed asRazorProject. So, this change mergesRazorProjectintoRazorProjectFileSystem.I've done a fair amount of clean up and called that out in the commit history. In addition, I added a new
InMemoryFileContenthelper class to remove a bunch of duplicated code converting strings into UTF byte arrays.