Update BDN version to support more net10.0 testing. #4622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o be used. Updated two other method calls to match 4.12.0 signatures.
|
It seems in the BDN update that the identifier for wasm on .NET 10 is wasmnet10_0, and Mono is Mono10_0. I think we need to update the code to use the underscore for it to work? |
Probably, at least for wasmnet10_0. I will check and see for mono but we may be using the generic version there. |
…e latest BDN update.
|
I verified that we only use the versioned runtime argument for wasm runs. MonoAotLLVM uses monoaotllvm and mono JIT does not appear to pass anything. So I updated the argument we pass to for wasm to be wasmnet10_0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update BDN version to support more net10.0 testing. This should fix WASM runs.