Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark resource auth type public #7250

Merged
merged 5 commits into from
Jan 25, 2025

Conversation

FullStackChef
Copy link
Contributor

Recreated from #7135

Make UseAccessKeyAuthentication public so that it is accessible for package extensibility

Description

When extending on the Azure.Redis package (e.g. CommunityToolkit/Aspire#371) there needs to be a way to determine early (outside of ConfigureInfrastructure) whether the Redis has been configured with AccessKeyAuthentication in order to configure appropriate parameters and outputs

Fixes # (issue)
Have not yet created an issue

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • [] Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 25, 2025
@FullStackChef
Copy link
Contributor Author

@davidfowl @eerhardt @sebastienros Apologies for mucking up the last PR (I'm used to devops and single source repos)

@davidfowl davidfowl merged commit 714469d into dotnet:main Jan 25, 2025
9 checks passed
@davidfowl
Copy link
Member

tks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants