Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Replace the logger package with a more flexible log package. #1119

Merged
merged 5 commits into from
Jan 10, 2025

Conversation

renaudhartert-db
Copy link
Contributor

@renaudhartert-db renaudhartert-db commented Jan 9, 2025

What changes are proposed in this pull request?

This PR replace the logger package with a simpler, more flexible log package. This is likely not the final version of the logger but it is an improvement in terms of interface compare to the previous version.

How is this tested?

New package is 100% unit tested.

@renaudhartert-db renaudhartert-db changed the title Renaud.hartert/sdkmod logger [Internal] Replace the logger package with a more flexible log package. Jan 9, 2025
@renaudhartert-db renaudhartert-db marked this pull request as ready for review January 9, 2025 15:10
Copy link

github-actions bot commented Jan 9, 2025

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-go

Inputs:

  • PR number: 1119
  • Commit SHA: 0d4e0720ca43dc80442df1fd90f26429fa4e6b42

Checks will be approved automatically on success.

databricks/log/log.go Show resolved Hide resolved
databricks/log/log_test.go Show resolved Hide resolved
examples/http-proxy/client/main.go Show resolved Hide resolved
httpclient/fixtures/named.go Show resolved Hide resolved
openapi/code/load.go Show resolved Hide resolved
httpclient/fixtures/stub.go Show resolved Hide resolved
@renaudhartert-db renaudhartert-db added this pull request to the merge queue Jan 10, 2025
Merged via the queue into dev/sdk-mod with commit 09682fd Jan 10, 2025
15 checks passed
@renaudhartert-db renaudhartert-db deleted the renaud.hartert/sdkmod-logger branch January 10, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants