Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #92

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+9 −9
Open

Update README.md #92

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9e8580e
Update README.md
TomAugspurger Aug 20, 2020
8b0bd8a
use frigate
TomAugspurger Aug 20, 2020
842b6e6
restore readme
TomAugspurger Aug 20, 2020
d70df01
restore readme
TomAugspurger Aug 20, 2020
941088e
update gen instructions
TomAugspurger Aug 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions dask/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ Dask

This chart will deploy the following:

- 1 x Dask scheduler with port 8786 (scheduler) and 80 (Web UI) exposed on an external LoadBalancer (default)
- 1 x Dask scheduler with port 8786 (scheduler) and 80 (Web UI)
- 3 x Dask workers that connect to the scheduler
- 1 x Jupyter notebook (optional) with port 80 exposed on an external LoadBalancer (default)
- 1 x Jupyter notebook (optional)
- All using Kubernetes Deployments

> **Tip**: See the [Kubernetes Service Type Docs](https://kubernetes.io/docs/concepts/services-networking/service/#publishing-services-service-types)
> for the differences between ClusterIP, NodePort, and LoadBalancer.
> for the differences between ClusterIP, NodePort, and LoadBalancer. To access the Dask Cluster from outside of the Kubernetes Cluster (from your laptop, say) you'll neeed to set `scheduler.serviceType` and `jupyter.serviceType` to `LoadBalancer`.

## Installing the Chart

Expand Down Expand Up @@ -65,7 +65,7 @@ The following table lists the configurable parameters of the Dask chart and thei
| `scheduler.image.pullPolicy` | Container image pull policy. | `"IfNotPresent"` |
| `scheduler.image.pullSecrets` | Container image [pull secrets](https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/). | `null` |
| `scheduler.replicas` | Number of schedulers (should always be 1). | `1` |
| `scheduler.serviceType` | Scheduler service type. set to `loadbalancer` to expose outside of your cluster. | `"ClusterIP"` |
| `scheduler.serviceType` | Scheduler service type. set to `LoadBalancer` to expose outside of your cluster. | `"ClusterIP"` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be a bug in Frigate because the comment in the values.yaml this is generated from looks correct.

https://github.com/dask/helm-chart/blob/master/dask/values.yaml#L14

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I had to guess it's https://github.com/rapidsai/frigate/blob/874493d8fbfd8c7fe94f13a709bcf7bf92cc680b/frigate/gen.py#L184.

I think it'd be best if frigate didn't try to be clever here. What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think dropping the capitalise call would be best.

| `scheduler.servicePort` | Scheduler service internal port. | `8786` |
| `scheduler.resources` | Scheduler pod resources. see `values.yaml` for example values. | `{}` |
| `scheduler.tolerations` | Tolerations. | `[]` |
Expand Down Expand Up @@ -100,7 +100,7 @@ The following table lists the configurable parameters of the Dask chart and thei
| `jupyter.image.pullPolicy` | Container image pull policy. | `"IfNotPresent"` |
| `jupyter.image.pullSecrets` | Container image [pull secrets](https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/). | `null` |
| `jupyter.replicas` | Number of notebook servers. | `1` |
| `jupyter.serviceType` | Scheduler service type. set to `loadbalancer` to expose outside of your cluster. | `"ClusterIP"` |
| `jupyter.serviceType` | Scheduler service type. set to `LoadBalancer` to expose outside of your cluster. | `"ClusterIP"` |
| `jupyter.servicePort` | Jupyter service internal port. | `80` |
| `jupyter.password` | Password hash. default hash corresponds to the password `dask`. | `"sha1:aae8550c0a44:9507d45e087d5ee481a5ce9f4f16f37a0867318c"` |
| `jupyter.env` | Environment variables. see `values.yaml` for example values. | `null` |
Expand Down