Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16695 test: make useradd and groupadd robust #15698

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

DAOS-16695 test: make useradd and groupadd robust #15698

wants to merge 1 commit into from

Conversation

daltonbohning
Copy link
Contributor

Make useradd and groupadd robust by using a common uid and gid across all clients.

Test-tag: DfuseMUPerms HarnessLaunchSetupTest always_passes,vm
Skip-unit-tests: true
Skip-fault-injection-test: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning self-assigned this Jan 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Ticket title is 'Group not setup correctly: daos_test_group_x1'
Status is 'In Progress'
Labels: 'md_on_ssd'
https://daosio.atlassian.net/browse/DAOS-16695

daltonbohning
daltonbohning commented Jan 7, 2025
View reviewed changes
src/tests/ftest/util/exception_utils.py Outdated
@@ -1,13 +1,19 @@
"""
(C) Copyright 2022-2023 Intel Corporation.
(C) Copyright 2025 Hewlett Packard Enterprise Development LP

SPDX-License-Identifier: BSD-2-Clause-Patent
"""

import os

from env_modules import get_module_list, show_avail
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ModuleNotFoundError: No module named 'env_modules'

@daltonbohning daltonbohning force-pushed the dbohning/daos-16695 branch 2 times, most recently from 2d734d7 to 4250b02 Compare January 8, 2025 17:01
@daltonbohning
DAOS-16695 test: make useradd and groupadd robust
fa3b546 
Make useradd and groupadd robust by using a common uid and gid across
all clients.

Test-tag: DfuseMUPerms HarnessLaunchSetupTest always_passes,vm
Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Dalton Bohning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@daltonbohning daltonbohning

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@daltonbohning