Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16766 container: don't create for cont lookup #15670

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

DAOS-16766 container: don't create for cont lookup #15670

wants to merge 5 commits into from
+15 −19

Conversation

wangshilong
Copy link
Contributor

If container is not found from LRU, that means it was evicted from cache. This should only happens on container stopped or destroyed. don't create it again to avoid any race.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@wangshilong
DAOS-16766 container: don't create for cont lookup
7b2b12c 
If container is not found from LRU, that means it was evicted from cache.
This should only happens on container stopped or destroyed. don't create
it again to avoid any race.

Signed-off-by: Wang Shilong <[email protected]>
@github-actions GitHub Actions
Copy link

Ticket title is 'erasurecode/multiple_rank_failure.py:EcodOnlineMultiRankFail.test_ec_multiple_rank_failure - daos container destroy DER_TIMEDOUT'
Status is 'In Progress'
Labels: '2.7.101tb,md_on_ssd,weekly_test'
https://daosio.atlassian.net/browse/DAOS-16766

@wangshilong wangshilong marked this pull request as ready for review January 2, 2025 01:58
@wangshilong wangshilong requested review from a team as code owners January 2, 2025 01:58
NiuYawei
NiuYawei requested changes Jan 7, 2025
View reviewed changes
src/container/srv_target.c
rc = cont_child_lookup(tls->dt_cont_cache, cont_uuid, pool_uuid,
true /* create */, ds_cont);
rc = cont_child_lookup(tls->dt_cont_cache, cont_uuid, pool_uuid, false /* create */,
ds_cont);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment & code in cont_child_stop() will be incorrect due to this change, please modify cont_child_stop() accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiuYawei NiuYawei NiuYawei requested changes

@Nasf-Fan Nasf-Fan Awaiting requested review from Nasf-Fan

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangshilong @NiuYawei