fix: shared post empty state #2615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebelchris
requested review from
omBratteng,
ilasw,
sshanzel,
nensidosari and
AmarTrebinjac
omBratteng
reviewed
Jan 24, 2025
rebelchris
commented
Jan 24, 2025
omBratteng
approved these changes
Jan 24, 2025
capJavert
approved these changes
Jan 24, 2025
| @@ -21,6 +22,10 @@ const worker: Worker = { | |||
| typeof flags === 'string' ? JSON.parse(flags as string) : flags; | |||
| const { deletedBy } = parsedFlags; | |||
|
|
|||
| if (deletedBy === DELETED_BY_WORKER) { | |||
capJavert
approved these changes
Jan 24, 2025
idoshamun
reviewed
Jan 26, 2025
idoshamun
reviewed
Jan 26, 2025
| .createQueryBuilder() | ||
| .update() | ||
| .where({ | ||
| sharedPostId: post.id, |
There was a problem hiding this comment.
Make sure we have index for sharedPostId
There was a problem hiding this comment.
We do have one:
IDX_sharedPostId (it's just singular, but for this query probably ok)
sshanzel
reviewed
Jan 27, 2025
sshanzel
approved these changes
Jan 27, 2025
idoshamun
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple things that happen here:
a. If has commentary we set it to not show on feed
b. If no commentary we simply set as soft deleted, but add the new DELETED_BY_WORKER flag, this way no reputation is lost.