Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: share link bar overflow #4109

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: share link bar overflow #4109

wants to merge 6 commits into from
+41 −34

Conversation

AmarTrebinjac
Copy link
Contributor

@AmarTrebinjac AmarTrebinjac commented Jan 26, 2025 •
edited
Loading

Changes

This was apparently a known issue that was found difficult to reproduce, so since I had it consistently on my Chrome on Linux, I thought I might as well squash the bug. 😁

Diff looks kinda big, but its due to wrapping elements. It's mainly wrapping input + button together, adding a divider and changing classes.

before:
image

after:
image

Mobile

before:
image

after:
image

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://mi-771.preview.app.daily.dev

@vercel Vercel
Copy link

vercel bot commented Jan 26, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Jan 26, 2025 3:28am
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) Jan 26, 2025 3:28am

@AmarTrebinjac AmarTrebinjac marked this pull request as ready for review January 26, 2025 03:28
@AmarTrebinjac AmarTrebinjac requested a review from a team as a code owner January 26, 2025 03:28
sshanzel
sshanzel approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@sshanzel sshanzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you applied changes on mobile view also. Would you be able to attach screenshots for before and after of that too?

@AmarTrebinjac
Copy link
Contributor Author

AmarTrebinjac commented Jan 27, 2025 •
edited
Loading

Looks like you applied changes on mobile view also. Would you be able to attach screenshots for before and after of that too?

@sshanzel The mobile changes were just to adjust for the new divider and padding. I attached some screenshots 😄

I do notice the line isn't going end-to-end anymore, but it aligns with the the rest of the items this way 😅
Do we keep or fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshanzel sshanzel sshanzel approved these changes

@rebelchris rebelchris Awaiting requested review from rebelchris rebelchris is a code owner automatically assigned from dailydotdev/web-team

@omBratteng omBratteng Awaiting requested review from omBratteng omBratteng is a code owner automatically assigned from dailydotdev/web-team

@ilasw ilasw Awaiting requested review from ilasw ilasw is a code owner automatically assigned from dailydotdev/web-team

@capJavert capJavert Awaiting requested review from capJavert capJavert is a code owner automatically assigned from dailydotdev/web-team

@nensidosari nensidosari Awaiting requested review from nensidosari nensidosari is a code owner automatically assigned from dailydotdev/web-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmarTrebinjac @sshanzel