chore: build primary sample app #847
Open
+31
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
SDK binary size reports 📊SDK binary size of this PRSDK binary size diff report between this PR and the main branch |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #847 +/- ##
==========================================
+ Coverage 63.74% 64.98% +1.23%
==========================================
Files 153 153
Lines 6294 6294
==========================================
+ Hits 4012 4090 +78
+ Misses 2282 2204 -78 ☔ View full report in Codecov by Sentry. |
mrehan27
commented
Jan 10, 2025
| fi | ||
|
|
||
| # Export the groups as an environment variable | ||
| echo "firebase_distribution_groups=$(IFS=','; echo "${distribution_groups[*]}")" >> $GITHUB_ENV |
There was a problem hiding this comment.
I tested final value with dummy input, and it seems to be working well.
Shahroz16
approved these changes
Jan 10, 2025
| @@ -67,13 +67,37 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
|
|
|||
| - name: Set Default Firebase Distribution Groups | |||
| run: | | |||
There was a problem hiding this comment.
I think we can extract the variable initialization from run to env, something like
- name: Set Firebase Distribution Groups
shell: bash
env:
# Distribution group constants
ALL_BUILDS_GROUP: all-builds
FEATURE_BUILDS_GROUP: feature-branch
STABLE_BUILDS_GROUP: next
# Input variables
IS_PRIMARY_APP: ${{ matrix.apn-or-fcm == 'APN' }}
CURRENT_BRANCH: ${{ github.ref }}
run: |
# Initialize array with default group
distribution_groups=("$ALL_BUILDS_GROUP")
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
I personally find reading bash logic in Github actions steps to make the file harder to read and navigate.
Would it make things simpler if we pass which app is being built to Fastlane and keep the logic that decides which groups to publish to in the get_build_test_groups lane?
- We can send params
isPrimaryAppand whatever else is needed
This will also allow us to share the logic as we used to between repos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of: MBL-710
Changes
Build Sample Appsaction to push only primary app to relevant channelsget_build_test_groupslane to decouple from GitHub and accept arguments for passing Firebase distribution groups when distributing sample appsPlease refer to linked ticket for detailed expectations regarding channel distribution.