Explicit Crystal.once_init method
#15371
Draft
+142
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the implicit initialization of Thread and Fiber class variables with an explicit initializer since both should be initialized before `__crystal_once_init` is called. This is working for now because the `class_[getter|property]` macros in Thread and Fiber don't protect against either recursion nor parallel initializations, but we plan to protect them (using Mutex) which would immediately break with an infinite recursion: Mutex#lock -> Fiber#current -> Thread#current -> Mutex#lock -> ...
Prefer a def explictly called by `Crystal.init_runtime` over the implicit `__crystal_once_init` fun injected by the compiler. The fun is no longer defined for new compiler builds, however it's still defined to support older compiler releases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Crystal.once_initthat allows to remove theCrystal.once_mutex=setter.It also removes the need for the
__crystal_once_initfun that won't be defined anymore —it's only kept for the legacy implementation. This is one less compiler dependency on runtime.Follow up to #15369