Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove migrations migrated to shared #1090

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

Swatinem
Copy link
Contributor

All the migrations which have been migrated to shared and are being referenced via MIGRATION_MODULES can be removed from api, as that code is never being imported from here.

All the migrations which have been migrated to `shared` and are being referenced via `MIGRATION_MODULES` can be removed from `api`, as that code is never being imported from here.
@Swatinem Swatinem self-assigned this Jan 10, 2025
@Swatinem Swatinem requested review from adrian-codecov and a team as code owners January 10, 2025 13:27
@codecov-notifications
Copy link

codecov-notifications bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.12%. Comparing base (4c41647) to head (7b5c951).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1090      +/-   ##
==========================================
+ Coverage   96.02%   96.12%   +0.10%     
==========================================
  Files         831      829       -2     
  Lines       19563    19540      -23     
==========================================
- Hits        18785    18783       -2     
+ Misses        778      757      -21     
Flag Coverage Δ
unit 96.11% <ø> (+3.78%) ⬆️
unit-latest-uploader 96.11% <ø> (+3.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@adrian-codecov adrian-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Godsend 😂 I had made a comment in another ticket to see if you could do this - thank you.

Left another comment as well but approved. Reemphasizing to manually test this in some capacity to ensure nothing breaks since it's a lot of files moved

@@ -1,2 +1 @@
from shared.django_apps.codecov_auth.models import *
from shared.django_apps.codecov_auth.models import _generate_key # noqa: F401
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this safe to remove? I forget specifically why this was here in the first place, maybe for some migrations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

searching for this across the code did not yield any results, so 🤷🏻‍♂️

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick search and found it here

models.TextField(default=core.models._gen_image_token, null=True),

So I think by completely removing that migration from API and putting it into Shared we should be able to delete it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Swatinem Swatinem enabled auto-merge January 14, 2025 14:33
@Swatinem Swatinem added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit fa372bf Jan 14, 2025
20 checks passed
@Swatinem Swatinem deleted the swatinem/rm-migrated-migrations branch January 14, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants