-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the quickstart to use the new 1.0 API #130
base: main
Are you sure you want to change the base?
Conversation
|
commit: |
I would prefer not to have the server code duplicated in a bunch of different places. I would much prefer that each client SDK repo contain only its client code, with a README linking to the module code in the main SpacetimeDB repository. Failing that, I would accept CI jobs which verify that the module code is line-for-line equal in the two repos. I want to avoid a situation (which we've been in several times in the past) in which each repo defines its own "quickstart-chat" module, with all the versions being different and mutually incompatible. |
Whoops! Apologies, that was supposed to be removed, not changed. Fixed. |
Description of Changes
I've renamed the
examples/quickstart
directory toexamples/quickstart-chat
for standardization purposes, and also updated the quickstart example project to be in line with the new 1.0 API and the new quickstart guide in the docs: clockworklabs/spacetime-docs#141.Note that I have also moved the implementation of the example from
quickstart-chat
toquickstart-chat/client
. I felt that this would allow for people to have a root directory withclient
andserver
. I will note that this is not how https://github.com/clockworklabs/SpacetimeDB/tree/master/crates/sdk/examples/quickstart-chat does it, so I'm open to change it back one level up if that is preferred. We would need to update the tutorial in that case.API
This is not an API breaking change.
Requires SpacetimeDB PRs
I do not believe it needs any.