Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column tailnum: Fixing flights and planes #99

Merged
merged 6 commits into from
Nov 28, 2023
Merged

Conversation

beatrizmilz
Copy link
Collaborator

@beatrizmilz beatrizmilz commented Nov 23, 2023

While translating, @scopinho noticed that the datasets planes and flights are used to show join operations, using the tailnum column as a key.

But when we translated, we didn't notice that was the same column, and in each dataset this column has different name: cauda and numero_cauda.

So this PR changes the name of the two columns to "codigo_cauda".

Copy link
Contributor

@scopinho scopinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beatrizmilz , olhando o conteúdo e descrição, me parece mais adequado usar codigo ao invés de número (até pq tem letras tb). Veja o que acha.

inst/specs/flights.yml Outdated Show resolved Hide resolved
inst/specs/flights.yml Outdated Show resolved Hide resolved
inst/specs/planes.yml Outdated Show resolved Hide resolved
inst/specs/planes.yml Outdated Show resolved Hide resolved
beatrizmilz and others added 4 commits November 23, 2023 17:59
Co-authored-by: Eric Scopinho <[email protected]>
Co-authored-by: Eric Scopinho <[email protected]>
Co-authored-by: Eric Scopinho <[email protected]>
Co-authored-by: Eric Scopinho <[email protected]>
@beatrizmilz beatrizmilz added the ready-to-merge PR's that are ready to be merged label Nov 28, 2023
@beatrizmilz beatrizmilz merged commit b7b6878 into master Nov 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge PR's that are ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants