Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace 'whitelist' with 'allowlist' #937

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

drakirnosslin
Copy link
Collaborator

Affected Components

  • Content & Marketing
  • Pricing
  • Test
  • [ X ] Docs
  • Learn
  • Other

Pre-Requisites

  • Code is linted (npm run lint)

Notes for the Reviewer

Feedback from https://app.intercom.com/a/inbox/ep3ft8gg/inbox/conversation/135570604715690

New Dependency Submission

Screenshots

Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
checklyhq-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 2:21pm

Copy link
Collaborator

@stefanjudis stefanjudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This would also need a redirect though.

Do you have access here? https://github.com/checkly/checkly-marketing-website/blob/main/next.config.js#L177

@drakirnosslin drakirnosslin merged commit c29aaf6 into main Nov 13, 2023
5 checks passed
@drakirnosslin drakirnosslin deleted the allowList_blockList_update branch November 13, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants